Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable libpq-compatible "postgresql" URL schemes #251

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Aug 14, 2023

For libpq compatibility, the following additional schemes are now accepted in database URLs:

  • "postgresql"
  • "postgresql+tcp"
  • "postgresql+uds"

Fixes #250.

@gwynne gwynne added enhancement New feature or request semver-patch Internal changes only labels Aug 14, 2023
@gwynne gwynne requested review from vzsg, 0xTim and MahdiBM August 14, 2023 15:35
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #251 (dc22329) into main (81d1106) will not change coverage.
The diff coverage is 100.00%.

❗ Current head dc22329 differs from pull request most recent head 73c1673. Consider uploading reports for the commit 73c1673 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage   36.27%   36.27%           
=======================================
  Files          13       13           
  Lines         736      736           
=======================================
  Hits          267      267           
  Misses        469      469           
Files Changed Coverage Δ
Sources/PostgresKit/SQLPostgresConfiguration.swift 85.10% <100.00%> (ø)

@gwynne gwynne enabled auto-merge (squash) August 14, 2023 15:41
@MahdiBM
Copy link
Contributor

MahdiBM commented Aug 14, 2023

They were 3 mighty meaningful whitespaces though!
Thanks :)

@gwynne gwynne merged commit 80ab773 into main Aug 14, 2023
19 checks passed
@gwynne gwynne deleted the allow-compatible-url-schemes branch August 14, 2023 15:54
@penny-for-vapor
Copy link

These changes are now available in 2.12.2

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLPostgresConfiguration does not allow the postgresql:// URL scheme
4 participants