JWTKit 5, FoundationEssentials-only + more#253
Conversation
0xTim
left a comment
0xTim
left a comment
There was a problem hiding this comment.
Few comments to improve things but LGTM
| @@ -1,5 +1,6 @@ | |||
| import DiscordBM | |||
| import JWTKit | |||
| import struct Foundation.Date | |||
There was a problem hiding this comment.
Shouldn't this be FoundationEssentials.Date to avoid linking all of Foundation?
| @@ -1,4 +1,4 @@ | |||
| import Foundation | |||
| import Foundation /// Need to import the whole thing for the `String.split()` function call below? | |||
There was a problem hiding this comment.
It should be in essentials unless it relies on ICU to ensure unicode is split correctly but I don't think that's the case, I thought that was all reimplemented in Swift for this reason
There was a problem hiding this comment.
Not sure what exactly is going on but things don't compile without importing the whole thing.
Something about CharacterSet I think, for one.
There was a problem hiding this comment.
Ah right IIRC CharacterSet is still not ported over? There were some issues around it in the main OpenAPIGenerator repo.
There was a problem hiding this comment.
This is my own comment from a few months ago. Apparently it was accurate:
apple/swift-openapi-runtime#107 (comment)
There was a problem hiding this comment.
Yes, the problem was CharacterSet: e96f991
2 participants
No description provided.