Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warnings as errors #193

Merged
merged 11 commits into from
Sep 23, 2024
Merged

Show warnings as errors #193

merged 11 commits into from
Sep 23, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Sep 11, 2024

No description provided.

@ptoffy ptoffy requested a review from 0xTim September 11, 2024 10:56
@ptoffy ptoffy requested a review from gwynne as a code owner September 11, 2024 10:56
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but looks like we have some issues to fix 😆

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.28%. Comparing base (0601ef5) to head (cebdea8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ources/JWTKit/Utilities/CustomizedJSONCoders.swift 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #193   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files          60       60           
  Lines        1424     1424           
=======================================
  Hits         1186     1186           
  Misses        238      238           
Files with missing lines Coverage Δ
Sources/JWTKit/Claims/LocaleClaim.swift 100.00% <ø> (ø)
...ources/JWTKit/Utilities/CustomizedJSONCoders.swift 50.00% <50.00%> (ø)

@ptoffy ptoffy linked an issue Sep 11, 2024 that may be closed by this pull request
@ptoffy ptoffy merged commit 7a3bfc5 into main Sep 23, 2024
10 checks passed
@ptoffy ptoffy deleted the ci branch September 23, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Warnings as Errors in CI
2 participants