Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility for iOS 15 and friends #181

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Add compatibility for iOS 15 and friends #181

merged 3 commits into from
Aug 15, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Jul 29, 2024

Fix #180

@ptoffy ptoffy requested review from 0xTim and Joannis July 29, 2024 15:47
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (f26649c) to head (1a73dfe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files          60       60           
  Lines        1413     1413           
=======================================
  Hits         1113     1113           
  Misses        300      300           

@@ -5,9 +5,9 @@ let package = Package(
name: "jwt-kit",
platforms: [
.macOS(.v13),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to bump this to 12 to line up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few errors around EC keys about missing conformances with .macOS < 13. Also JSONDecoder and JSONEncoder are only Sendable in 13+

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean we can try solving them but not sure it's worth it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the issues with EC keys? Because surely we'll have the same issues on iOS 15

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's worth being really annoying and adding CI for iOS (including 15) so see what issues we'd hit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is Crypto doesn't specify iOS requirements (or any besides macOS) so there's no issues with that

Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me. I'd recommend lowering this as much as feasible, going even back to iOS 13 if possible. You can always use @available annotations if need be for specific features.

@0xTim 0xTim merged commit 831fe3c into main Aug 15, 2024
10 checks passed
@0xTim 0xTim deleted the ios-15 branch August 15, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lower minimum iOS version
3 participants