Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the queues.md page to add a little extra info about testing #1008

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Improved the queues.md page to add a little extra info about testing #1008

merged 3 commits into from
Nov 3, 2024

Conversation

Dracks
Copy link
Contributor

@Dracks Dracks commented Oct 22, 2024 •
edited
Loading

  • Added a small brief of the asyncDriver to allow people know you can use that for testing

@Dracks Dracks requested review from 0xTim and gwynne as code owners October 22, 2024 14:46
gwynne
gwynne requested changes Oct 22, 2024
View reviewed changes
@Dracks Dracks requested a review from gwynne October 22, 2024 17:58
gwynne
gwynne requested changes Oct 22, 2024
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of grammatical and spelling suggestions

@gwynne
Copy link
Member

gwynne commented Oct 22, 2024

Note: The failing CI is not the fault of this PR; fly.io's docs seem to be missing pieces of themselves.

gwynne
gwynne approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@Dracks Dracks changed the title Improved the queues.md page to add a little extra info about testing, and update the fluent community driver Improved the queues.md page to add a little extra info about testing Oct 22, 2024
@Dracks
Copy link
Contributor Author

Dracks commented Oct 22, 2024

I changed the title, to drop the update of the driver

0xTim
0xTim approved these changes Nov 3, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xTim 0xTim merged commit a0c7fd2 into vapor:main Nov 3, 2024
1 check passed
@penny-for-vapor penny-for-vapor bot mentioned this pull request Nov 3, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dracks @gwynne @0xTim