SHS-NG M8: Delete stale application data from SHS. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanzin
force-pushed
the
shs-ng/M7
branch
2 times, most recently
from
bb24425 to
277e8de
Compare
There was a problem hiding this comment.
change map{..}.getOrElse(false) to exists
There was a problem hiding this comment.
This line is quite duplicated with line 525..Maybe invalidate UI if UI is active, and then delete the kvstore file.
Detect the deletion of event log files from storage, and remove data about the related application attempt in the SHS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect the deletion of event log files from storage, and remove
data about the related application attempt in the SHS.