Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return error cause in http response from gateway #242

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Conversation

wenfengwang
Copy link
Contributor

@wenfengwang wenfengwang commented Sep 7, 2022

What problem does this PR solve?

Issue Number: #167

Problem Summary

This problem caused by cloudevents go-sdk, and it was fixed in cloudevents/sdk-go#785

What is changed and how does it work?

upgrade SDK version to v2.11.0, and format output of vsctl event put

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Before:
image

After:
image

  • No code

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #242 (3438988) into main (3f72df1) will increase coverage by 0.03%.
The diff coverage is 40.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   63.50%   63.54%   +0.03%     
==========================================
  Files         118      118              
  Lines       11353    11353              
==========================================
+ Hits         7210     7214       +4     
+ Misses       3589     3586       -3     
+ Partials      554      553       -1     
Impacted Files Coverage Δ
internal/gateway/gateway.go 69.00% <40.00%> (ø)
internal/timer/timingwheel/timingwheel.go 79.02% <0.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe92767...3438988. Read the comment docs.

@ifplusor ifplusor merged commit 7ae4d3b into main Sep 7, 2022
@ifplusor ifplusor changed the title fix: issue 167 feat: return error cause in http response from gateway Sep 7, 2022
@ifplusor
Copy link
Collaborator

ifplusor commented Sep 7, 2022

I think this PR can not solve #167, it is only a little part.

@ifplusor ifplusor added this to the v0.3 milestone Sep 7, 2022
@wenfengwang wenfengwang deleted the fix-issue branch September 10, 2022 07:45
wenfengwang added a commit that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants