Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generator to create unicode String #1109

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

cketti
Copy link
Contributor

@cketti cketti commented Jun 25, 2024

Generate the final unicode string instead of calling the String(int[], int, int) constructor at runtime.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better

@@ -40,7 +40,7 @@ internal class AndroidxEmoji2 internal constructor(

override fun equals(other: Any?): Boolean {
if (this === other) return true
if (other == null || this::class != other::class) return false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update your branch with the latest changes from master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like #1106 didn't include the update to the template.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad. Then never mind! Thanks for the change

@vanniktech vanniktech merged commit 6926f38 into vanniktech:master Jun 25, 2024
1 check passed
@cketti cketti deleted the generate_unicode_strings branch June 25, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants