Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch ctgan batchsize1 #263

Merged
merged 11 commits into from
Apr 12, 2024

Conversation

bvanbreugel
Copy link
Contributor

@bvanbreugel bvanbreugel commented Mar 19, 2024

Description

Fixes CTGAN error when batch size=1 (e.g. which can happen for the last batch in the epoch). Literally only specifies to squeeze only the last dimension when computing the gradient (i.e. whole PR is adding "-1" as squeeze argument).

Affected Dependencies

None

How has this been tested?

  • ran CTGAN to ensure it's now fixed
  • ran fast tests

Checklist

@bvanbreugel bvanbreugel marked this pull request as draft March 19, 2024 15:28
@bvanbreugel bvanbreugel marked this pull request as ready for review April 11, 2024 14:25
Copy link
Contributor

@robsdavis robsdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robsdavis robsdavis merged commit 44cd36d into vanderschaarlab:main Apr 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants