Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipif goggle tests #170

Merged
merged 13 commits into from
Apr 4, 2023
Merged

Skipif goggle tests #170

merged 13 commits into from
Apr 4, 2023

Conversation

robsdavis
Copy link
Contributor

@robsdavis robsdavis commented Apr 3, 2023 •
edited by bcebere
Loading

Description

Skip goggle tests if dependencies not installed. Closes #169

Also:
Fixing failing tests for GAN:

  • pin torch<2.0
  • pin pandas<2.0
  • update workflows to install .[testing] not .[all]
  • Test CORE and GOGGLE separately.
  • handle plugins that cannot be loaded(with missing deps)

Checklist

@robsdavis robsdavis linked an issue Apr 3, 2023 that may be closed by this pull request
Skip goggle tests if goggle dependencies not imported #169
Closed
@robsdavis robsdavis merged commit 8ae952a into main Apr 4, 2023
@robsdavis robsdavis deleted the 169-skip-goggle-tests-if-goggle-dependencies-not-imported branch April 4, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcebere bcebere bcebere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip goggle tests if goggle dependencies not imported
2 participants
@robsdavis @bcebere