Fix bugs, including PBCDataloader
incorrect preprocessing
#152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix three bugs:
XGBSurvivalAnalysis
/XGBTimeSeriesSurvival
. The tests that would previously (at least in some cases) fail includetests/metrics/test_performance.py::test_evaluate_performance_survival_analysis[PerformanceEvaluatorXGB-test_plugin0]
. The fix was to change thestrategy
from"weibull"
to the more stable"debiased_bce"
.WindowLinearLayer.forward
, which would fail when a length zero tensor was provided (i.e. no static data case). The conditional only needs to run if static data is expected, so an extra check added to fix this. The tests that would previously (at least in some cases) fail include:tests/plugins/core/models/test_ts_tabular_vae.py::test_ts_vae_generation[GoogleStocksDataloader]
.PBCDataloader
.from synthcity.utils.datasets.time_series.pbc import PBCDataloader; PBCDataloader(as_numpy=True).load()
).Affected Dependencies
None.
How has this been tested?
Checklist