BUG-FIX: added kwargs to plugins #122
Conversation
|
@gsel9 Thank you for your contribution! Please fix the test errors, and I will merge the PR! Thanks! |
.pre-commit-config.yaml
Outdated
| @@ -33,7 +33,7 @@ repos: | |||
| "--extend-ignore=E203,W503" | |||
| ] | |||
| - repo: https://github.com/pre-commit/mirrors-mypy | |||
| rev: v0.812 | |||
| rev: v0.991 | |||
There was a problem hiding this comment.
mypy isn't the issue, this version shouldn't be changed.
The errors are from black.
Please revert the mypy version and run
pre-commit install
pre-commit run --all
it should be clear where the error is after that
There was a problem hiding this comment.
Long story short, it fixed the black issues on my end (I am a Mac user). However, I also raised a lot of other fixes when running the pre-commit tests locally. Is there a reason for using this specific version of mypy?
I will surely revert the mypy version and try to solve my orginal problem in a different way.
This reverts commit d65f10c.
| @@ -35,7 +35,7 @@ class MarginalDistributionPlugin(Plugin): | |||
|
|
|||
| def __init__(self, **kwargs: Any) -> None: | |||
| super().__init__( | |||
| sampling_strategy="marginal", | |||
| sampling_strategy="marginal", **kwargs | |||
There was a problem hiding this comment.
On my end it shows that black reformats this line to
super().__init__(sampling_strategy="marginal", **kwargs)I am not sure why black isn't doing the same on MacOS, since the version is pinned in the .pre-commit config.
|
I updated the |
|
It looks like Feel free to remove the |
A small fix of passing kwargs to the
uniform_samplerandmarginal_distirbutionsplugins that can be useful (at least to me). After changing the src code, I re-installed the package and successfully ran the relevant tests.