Backwards incompatible! HostClient can't switch between protocols #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valyala
reviewed
May 3, 2020
| @@ -46,11 +46,10 @@ type Request struct { | |||
|
|
|||
| keepBodyBuffer bool | |||
|
|
|||
| // Used by Server to indicate the request was received on a HTTPS endpoint. | |||
| // Client/HostClient shouldn't use this field but should depend on the uri.scheme instead. | |||
| isTLS bool | |||
There was a problem hiding this comment.
Do we really need for this field now?
There was a problem hiding this comment.
Yeah I also wanted to remove it, but the messy way URIs are handled prevents this. This needs to be set from Server so that the URI.parse call happening at some point can know if the server was http or https. We can't just set Request.uri.scheme instead because a Request from a Server doesn't use the parsed uri but instead has this other form which then later gets parsed. Its all super messy but I don't see how I can improve that all without breaking the URI/``Request APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostClientconnects to its host though either HTTP or HTTPS. It should never switch between protocols. This breaks theHostClientmaps insideClient. There are two maps there:mis for http HostClientsmsis for https HostClientsUpdating a http
HostClientto https, while it is still inside map m will make all future requests to the given http host go to https. Since servers can serve different content on both ports this can break things.Thats why from now on
HostClientwill throw and error when it is used outsideClientand tries to follow a redirect to a different protocol.