Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve code issues from goreportcard.com #725

Merged
merged 1 commit into from
Jan 12, 2020
Merged

Resolve code issues from goreportcard.com #725

merged 1 commit into from
Jan 12, 2020

Conversation

panjf2000
Copy link
Contributor

@panjf2000
Copy link
Contributor Author

@erikdubbelboer

@panjf2000
Copy link
Contributor Author

panjf2000 commented Jan 12, 2020 •
edited
Loading

image
That is odd, I got a pass on my MacBook Pro and it only failed one OSX job on CI, else are all successful, is it occasional or what?

@panjf2000
Copy link
Contributor Author

@erikdubbelboer
Could you retry that failed job to verify whether it is just an occasional failure?

@panjf2000
Copy link
Contributor Author

panjf2000 commented Jan 12, 2020 •
edited
Loading

Well, all tests pass on my CI: https://travis-ci.com/panjf2000/fasthttp, so it could be an occasional failure.

@erikdubbelboer erikdubbelboer merged commit 59b28fe into valyala:master Jan 12, 2020
@erikdubbelboer
Copy link
Collaborator

Thanks!

@panjf2000 panjf2000 deleted the patch-1 branch January 12, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panjf2000 @erikdubbelboer