Allow a body for GET requests #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we can't skip parsing headers for GET requests anymore. This can be seen as good as it also allows us to reject malformed GET requests, something we didn't do before this. Performance also isn't affect much: benchmark old ns/op new ns/op delta BenchmarkClientGetEndToEnd1Inmemory-16 640 641 +0.16% BenchmarkClientGetEndToEnd10Inmemory-16 713 710 -0.42% BenchmarkClientGetEndToEnd100Inmemory-16 732 749 +2.32% BenchmarkClientGetEndToEnd1000Inmemory-16 759 774 +1.98% BenchmarkClientGetEndToEnd10KInmemory-16 785 808 +2.93% BenchmarkNetHTTPClientGetEndToEnd1Inmemory-16 5045 4954 -1.80% BenchmarkNetHTTPClientGetEndToEnd10Inmemory-16 5806 6225 +7.22% BenchmarkNetHTTPClientGetEndToEnd100Inmemory-16 7877 7998 +1.54% BenchmarkNetHTTPClientGetEndToEnd1000Inmemory-16 16603 16559 -0.27%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can't skip parsing headers for GET requests anymore. This
can be seen as good as it also allows us to reject malformed GET
requests, something we didn't do before this. Performance also isn't
affect much:
Fixes #670