Use 'go generate' in bytesconv.go #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikdubbelboer
requested changes
Sep 28, 2019
bytesconv_table_gen.go
Outdated
| ) | ||
|
|
||
| func main() { | ||
| var hex2intTable = func() [256]byte { |
There was a problem hiding this comment.
Can you change these to := declarations like hex2intTable := .... I prefer those, thanks!
bytesconv_table_gen.go
Outdated
| tmp[i] = v[i] | ||
| } | ||
| fmt.Fprintf(w, table, k, string(tmp)) | ||
| } |
There was a problem hiding this comment.
I would just replace the whole above code with:
fmt.Fprintf(w, "const hex2intTable = %q\n", hex2intTable)
fmt.Fprintf(w, "const toLowerTable = %q\n", toLowerTable)
fmt.Fprintf(w, "const toUpperTable = %q\n", toUpperTable)
fmt.Fprintf(w, "const quotedArgShouldEscapeTable = %q\n", quotedArgShouldEscapeTable)
fmt.Fprintf(w, "const quotedPathShouldEscapeTable = %q\n", quotedPathShouldEscapeTable)
bytesconv_table_gen.go
Outdated
| if err := ioutil.WriteFile("bytesconv_table.go", out, 0660); err != nil { | ||
| log.Fatal(err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove empty line.
|
|
||
| package fasthttp | ||
|
|
||
| ` |
There was a problem hiding this comment.
Can you move this constant to the top of the file, I prefer to have them there. Thanks.
bytesconv_table_gen.go
Outdated
| ` | ||
|
|
||
| const table = `const %s = %#v | ||
| ` |
There was a problem hiding this comment.
This one can then be removed.
|
Thanks for review! all done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lots of tables in bytesconv.go, maybe we could use 'go generate' to generate these tables in a new file, called 'bytesconv_table.go'. In this way we can reduce init-time and also speed up our conversion, since the table is a constant which defined in compile-time.