Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support huge read-only []byte response bodies #477

Merged
merged 3 commits into from
Feb 24, 2019

Conversation

cipriancraciun
Copy link
Contributor

See issue #469.

Copy link
Collaborator

@erikdubbelboer erikdubbelboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe add some test cases to verify that everything works. And so we can keep it working in the future as well when things change.

@erikdubbelboer
Copy link
Collaborator

@cipriancraciun would it be possible for you to add some tests to make sure everything keeps working correctly in the future?

@cipriancraciun
Copy link
Contributor Author

@cipriancraciun would it be possible for you to add some tests to make sure everything keeps working correctly in the future?

Sorry for deferring this, but I was a little busy. I'll try to add them during these days around new year's eve.

@cipriancraciun
Copy link
Contributor Author

So I've rebased my two commits based on the latest code, and added a few tests at the end of http_tests.go. Basically I check that the SetBodyRaw actually works as expected, if CopyTo and ResetBody work properly.

If I can make any other changes please let me know.

@erikdubbelboer erikdubbelboer merged commit 733a650 into valyala:master Feb 24, 2019
@erikdubbelboer
Copy link
Collaborator

Thanks.

@cipriancraciun cipriancraciun deleted the patches/body-raw branch August 12, 2019 10:06
@cipriancraciun cipriancraciun restored the patches/body-raw branch August 12, 2019 14:51
@cipriancraciun cipriancraciun deleted the patches/body-raw branch August 17, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants