Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dummy support for js,wasm #1955

Merged
merged 1 commit into from
Feb 14, 2025
Merged

add dummy support for js,wasm #1955

merged 1 commit into from
Feb 14, 2025

Conversation

pjebs
Copy link
Contributor

@pjebs pjebs commented Feb 13, 2025

@erikdubbelboer Can this be merged and a new version be tagged.

It is to support this: gofiber/fiber#3298 & nlepage/go-wasm-http-server#18

fasthttp wasn't building for GOOS=js GOARCH=wasm go build producing this build error:

../../go/pkg/mod/github.com/valyala/[email protected]/socket_other.go:11:48: undefined: syscall.SOCK_NONBLOCK
../../go/pkg/mod/github.com/valyala/[email protected]/socket_other.go:11:70: undefined: syscall.SOCK_CLOEXEC

@erikdubbelboer erikdubbelboer merged commit bb94b26 into valyala:master Feb 14, 2025
15 checks passed
@erikdubbelboer
Copy link
Collaborator

I'll tag a new version on Monday.

@pjebs
Copy link
Contributor Author

pjebs commented Feb 14, 2025

@erikdubbelboer Thanks

What will the new tag version be? I want to preemptively create a PR in Fiber.

@erikdubbelboer
Copy link
Collaborator

erikdubbelboer commented Feb 14, 2025

v1.59.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants