Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (request): expose req timeout #1878

Merged

Conversation

aarcex3
Copy link
Contributor

@aarcex3 aarcex3 commented Oct 1, 2024

Summary

Implemented GetRequestTimeout func to get the timeout attribute of the request.

Related Issue

#1745

pd: is this what you guys had in mind?. I still need to document this btw.

@erikdubbelboer
Copy link
Collaborator

Why as a string?

@aarcex3
Copy link
Contributor Author

aarcex3 commented Oct 3, 2024

Just a PoC, I was waiting for some guidance and suggestion.
What type of return data do you suggest?

@erikdubbelboer
Copy link
Collaborator

I think just returning a time.Duration is good. The most important part is the description of the function, it should describe exactly what this is for.

@aarcex3 aarcex3 changed the title feat (request): expose req timeout as string feat (request): expose req timeout Oct 4, 2024
@erikdubbelboer erikdubbelboer merged commit 0b74893 into valyala:master Oct 5, 2024
15 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants