Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable perfsprint linter; fix up lint issues #1727

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Mar 1, 2024

The PR enables the perfsprint linter in the golangci-lint configuration file. The fasthttp library is heavily focused on performance, making this linter a beneficial addition.

This PR fixes up the lint issues that arose from persprint. All of these were minor:

  • replace fmt.Errorf("msg") with errors.New("msg));
  • replace fmt.Sprintf("%d", n) with strconv.Itoa(n) in tests.

@erikdubbelboer erikdubbelboer merged commit 7e1fb71 into valyala:master Mar 2, 2024
15 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

@alexandear alexandear deleted the enable-perfsprint-linter branch March 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants