Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove redundant and outdated build constraints #1650

Merged
merged 1 commit into from
Nov 8, 2023
Merged

chore: Remove redundant and outdated build constraints #1650

merged 1 commit into from
Nov 8, 2023

Conversation

alexandear
Copy link
Contributor

This PR removes outdated // +build constraints (it was replaced by //go:build in Go 16) by running go fix ./....

We can remove OS-specific build constraints like //go:build windows if a file name ends with _windows.go (according to the doc).

@alexandear alexandear changed the title chore: Remove redundant build constraint chore: Remove redundant and outdated build constraints Nov 8, 2023
@alexandear alexandear mentioned this pull request Nov 8, 2023
Closed
@erikdubbelboer erikdubbelboer merged commit 7bd632c into valyala:master Nov 8, 2023
13 of 14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

@alexandear alexandear deleted the chore-remove-redundant-build-constraints branch November 9, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @erikdubbelboer