Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: HostClient.DialDualStack not work when using DoDeadline #1634

Merged
merged 1 commit into from
Oct 21, 2023
Merged

BUGFIX: HostClient.DialDualStack not work when using DoDeadline #1634

merged 1 commit into from
Oct 21, 2023

Conversation

cloudfly
Copy link
Contributor

If HostClient has DialDualStack=true and there is no custom Dial method specified, the DialDualStack setting will not work when sending requests using DoDeadline or DoTimeout.

This issue was introduced in this commit

@erikdubbelboer erikdubbelboer merged commit 772e4aa into valyala:master Oct 21, 2023
13 of 14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks! Good find!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudfly @erikdubbelboer