Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix round2_32 #1607

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix round2_32 #1607

merged 1 commit into from
Aug 24, 2023

Conversation

Duncaen
Copy link
Contributor

@Duncaen Duncaen commented Aug 24, 2023

There was a missing import in round2_32.go.

I split the tests into per int size files too, since unsafe.Sizeof(int(0)) == 4 runtime does not allow to pass 64 bit constants to 32 bit functions at compile time. Not sure if there is a better solution.

@Duncaen
Copy link
Contributor Author

Duncaen commented Aug 24, 2023

round2_64 is missing x |= x >> 32 not sure if this is intentional because of the 100MB cut-off.

@erikdubbelboer erikdubbelboer merged commit 6aea1e0 into valyala:master Aug 24, 2023
13 of 14 checks passed
@erikdubbelboer
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants