Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client's example code #1539

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Refactor client's example code #1539

merged 2 commits into from
Apr 18, 2023

Conversation

Imm0bilize
Copy link
Contributor

  • Use errors.Is for to compare errors
  • Reducing the level of nesting for easier code perception ( using switch and removing some else)

erikdubbelboer
erikdubbelboer requested changes Apr 17, 2023
View reviewed changes
examples/client/client.go Outdated Show resolved Hide resolved
@Imm0bilize @erikdubbelboer
Update examples/client/client.go
67eec54 
Remove closure

Co-authored-by: Erik Dubbelboer <[email protected]>
@erikdubbelboer erikdubbelboer merged commit cdea4fe into valyala:master Apr 18, 2023
@erikdubbelboer
Copy link
Collaborator

Thanks!

@alexandear alexandear mentioned this pull request Apr 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikdubbelboer erikdubbelboer erikdubbelboer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Imm0bilize @erikdubbelboer