Fix issue #1529 : DoTimeout timeout failure #1535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1529 , the main problem with the timeout failure is that req.timeout is not passed to dial to pause the dialing in time. One solution is to create a temporary dial. In order not to affect the original dial of HostClient, I choose to add the dialTimeout parameter in the dialHostHard function to control the dialing time. It will fail if HostClient.dial has been set, but general users should not set dial. In fact, I think the most appropriate solution is to make HostClient have a Dialer with a timeout attribute so that timeout can be set separately without affecting other settings and use HostClient.Dialer.dial instead of HostClient.dial, but obviously this will change a lot of code.