Add Go 1.19 Support #1355
Merged
Add Go 1.19 Support #1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text. ref: https://tip.golang.org/doc/go1.19 ref: https://tip.golang.org/doc/comment
|
TBR |
erikdubbelboer
requested changes
Aug 14, 2022
doc.go
Outdated
Comment on lines
37
to
47
| - Server and client address. | ||
|
|
||
| - Per-request logger. | ||
|
|
||
| - Unique request id. | ||
|
|
||
| - Request start time. | ||
|
|
||
| - Connection start time. | ||
|
|
||
| - Request sequence number for the current connection. |
There was a problem hiding this comment.
These need to be sub bullet points like the original.
doc.go
Outdated
Comment on lines
15
to
33
| - The number of concurrent connections. | ||
|
|
||
| - The number of concurrent connections per client IP. | ||
|
|
||
| - The number of requests per connection. | ||
|
|
||
| - Request read timeout. | ||
|
|
||
| - Response write timeout. | ||
|
|
||
| - Maximum request header size. | ||
|
|
||
| - Maximum request body size. | ||
|
|
||
| - Maximum request execution time. | ||
|
|
||
| - Maximum keep-alive connection lifetime. | ||
|
|
||
| - Early filtering out non-GET requests. |
There was a problem hiding this comment.
These need to be sub bullet points like the original.
|
@erikdubbelboer Go doc comments do not support nested lists. https://tip.golang.org/doc/comment#mistakes Maybe we can mix list markers like the example? Since bullet markers do not introduce list items in a numbered list. |
|
Thanks! |
| go-version: 1.18.x | ||
| go-version: 1.19.x | ||
|
|
||
| - name: Get Go cache paths |
There was a problem hiding this comment.
@Aoang curious why you ended up doing this? In wazero, we're noticing the cache doesn't seem to work for golangci-lint and wondering if there's some difference between this and hard-coding (considering it is only run with ubuntu). Any thoughts appreciated!
There was a problem hiding this comment.
continue tetratelabs/wazero#804
bbenzikry
pushed a commit
to bbenzikry/fasthttp
that referenced
this pull request
Sep 11, 2022
* Update Go Version to Go1.19.x And add cache * Fix CI Line endings * Update test CI Go Version to Go1.19.x And add cache * Update Gosec Security Scanner CI to securego/[email protected] * Format comment Go 1.19 adds support for links, lists, and clearer headings in doc comments. As part of this change, gofmt now reformats doc comments to make their rendered meaning clearer. See “Go Doc Comments” for syntax details and descriptions of common mistakes now highlighted by gofmt. As another part of this change, the new package go/doc/comment provides parsing and reformatting of doc comments as well as support for rendering them to HTML, Markdown, and text. ref: https://tip.golang.org/doc/go1.19 ref: https://tip.golang.org/doc/comment * Fix doc structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.