-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streaming request body #622
Comments
Currently working on/testing this feature |
At the moment not. By design fasthttp waits until the whole request is in memory before it calls the handler. @kirillDanshin is working on changing this so keep an eye on this repo. |
cool.......... |
@kirillDanshin Could you update your progress? |
Any updates? Seems like a big thing |
sorry for delay. this feature is currently in production testing. had to reimplement it again due to insufficient performance. |
@kirillDanshin can you maybe make a pull request already (maybe in Draft mode?) so people can look at the code? |
@kirillDanshin any updates on this? |
@kirillDanshin Could you update your progress? |
@kirillDanshin could you share what you got so far, maybe we could help? |
@kirillDanshin could you share your code ? |
@kirillDanshin any updates on this? |
@kirillDanshin any update on this? |
Signed-off-by: Kirill Danshin <[email protected]>
any update? i use the issue-622 branch and it totally not work. the handler blocking at 'appendBodyFixedSize'. |
@jan4984 please provide an example of this issue |
@kirillDanshin Thank you so much for your work, this is a really helpful feature, any idea on when the PR will be merged? |
Hello! First of all, thanks for the awesome work.
I'm building a simple file server that receives files from clients. The files are presented in the raw request body (i.e. no multipart/form-data), and file sizes can be several hundred megabytes large. fasthttp seems to have a small default request body limit (4MB), and when I try to increase that limit via MaxRequestBodySize I get out of memory error when uploading large files. Is there a way to stream request body directly so it uses only constant memory?
The text was updated successfully, but these errors were encountered: