-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastHTTP doesn't strip tabs from header values #1808
Labels
Comments
ksw2000
added a commit
to ksw2000/fasthttp
that referenced
this issue
Jul 22, 2024
When FastHTTP receives a header value suffixed or prefixed with tabs, they should be stripped.
ksw2000
added a commit
to ksw2000/fasthttp
that referenced
this issue
Jul 24, 2024
erikdubbelboer
pushed a commit
that referenced
this issue
Jul 28, 2024
Fixed in #1808 |
newacorn
pushed a commit
to newacorn/fasthttp
that referenced
this issue
Oct 19, 2024
When FastHTTP receives a header value suffixed or prefixed with tabs, they should be stripped.
newacorn
pushed a commit
to newacorn/fasthttp
that referenced
this issue
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When FastHTTP receives a header value suffixed or prefixed with tabs, they should be stripped according to the RFCs. This is what nearly all other HTTP implementations do, including AIOHTTP, Apache httpd, Cheroot, Go net/http, H2O, HAProxy, Hyper, Hypercorn, Jetty, Libsoup, Lighttpd, Mongoose, Netty, Node.js, LiteSpeed, Passenger, Tomcat, Tornado, Twisted, Unicorn, Uvicorn, Waitress, and WEBrick.
Instead, FastHTTP allows the tabs to persist into the header value.
This can be confirmed by
Notably, spaces are correctly stripped. Presumably, the patch should change this function to strip tabs in addition to spaces.
The text was updated successfully, but these errors were encountered: