Skip to content

Commit

Permalink
Switch Pipeline types to extend NodeBase
Browse files Browse the repository at this point in the history
This doesn't work because the `type` values are not compatible.
  • Loading branch information
mAAdhaTTah committed Jul 22, 2018
1 parent 094ef31 commit 39e7ee6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/babel-parser/src/types.js
Original file line number Diff line number Diff line change
Expand Up @@ -571,22 +571,22 @@ export type PipelineBody = NodeBase & {
type: "PipelineBody",
};

export type PipelineBareFunctionBody = PipelineBody & {
export type PipelineBareFunctionBody = NodeBase & {
type: "PipelineBareFunctionBody",
callee: Expression,
};

export type PipelineBareConstructorBody = PipelineBody & {
export type PipelineBareConstructorBody = NodeBase & {
type: "PipelineBareConstructorBody",
callee: Expression,
};

export type PipelineBareAwaitedFunctionBody = PipelineBody & {
export type PipelineBareAwaitedFunctionBody = NodeBase & {
type: "PipelineBareAwaitedFunctionBody",
callee: Expression,
};

export type PipelineTopicBody = PipelineBody & {
export type PipelineTopicBody = NodeBase & {
type: "PipelineTopicBody",
expression: Expression,
};
Expand Down

1 comment on commit 39e7ee6

@mAAdhaTTah
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicolo-ribaudo I think this addresses your suggestion RE the Pipeline types, but could you verify?

Please sign in to comment.