Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): tooltipEnable inconsistent value #4911

Merged

Conversation

benj0c
Copy link
Contributor

@benj0c benj0c commented Dec 7, 2018

Fixes #4910

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #4911 into development will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4911      +/-   ##
===============================================
- Coverage         74.7%   74.63%   -0.08%     
===============================================
  Files              276      276              
  Lines             8385     8385              
  Branches          1594     1594              
===============================================
- Hits              6264     6258       -6     
- Misses            1680     1687       +7     
+ Partials           441      440       -1
Impacted Files Coverage Δ
src/tooltip/tooltip.directive.ts 58.87% <0%> (ø) ⬆️
src/utils/triggers.ts 65% <0%> (-5%) ⬇️
src/component-loader/component-loader.class.ts 74.1% <0%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582eb7...617db10. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #4911 into development will decrease coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4911      +/-   ##
===============================================
- Coverage         74.7%   74.63%   -0.08%     
===============================================
  Files              276      276              
  Lines             8385     8385              
  Branches          1594     1594              
===============================================
- Hits              6264     6258       -6     
- Misses            1680     1687       +7     
+ Partials           441      440       -1
Impacted Files Coverage Δ
src/tooltip/tooltip.directive.ts 58.87% <0%> (ø) ⬆️
src/utils/triggers.ts 65% <0%> (-5%) ⬇️
src/component-loader/component-loader.class.ts 74.1% <0%> (-2.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a582eb7...617db10. Read the comment docs.

@ludmilanesvitiy
Copy link
Contributor

Tooltip functionality tested, looks good.

@valorkin valorkin merged commit acb9dc3 into valor-software:development Dec 10, 2018
@ghost ghost removed the ready for merge label Dec 10, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants