Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dropdown): decompose manual triggering demo #4116

Merged
merged 4 commits into from
Apr 24, 2018

Conversation

YevheniiaMazur
Copy link

@YevheniiaMazur YevheniiaMazur commented Mar 27, 2018

PR Checklist

  • built and tested the changes locally.
  • updated API documentation.
  • updated demos.

Closes: #4110
What was done:

  • demo was decomposed into two parts:
    2partsoftrgg
  • was used direct change of isOpen property instead of creating special method for it:
    directchange
  • API documentation was updated:
    apidoc

@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@878bf9b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             development   #4116   +/-   ##
=============================================
  Coverage               ?   72.6%           
=============================================
  Files                  ?     254           
  Lines                  ?    8221           
  Branches               ?    1469           
=============================================
  Hits                   ?    5969           
  Misses                 ?    1897           
  Partials               ?     355
Impacted Files Coverage Δ
src/dropdown/bs-dropdown.directive.ts 74.01% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 878bf9b...7bed9ff. Read the comment docs.

here</a></li>
</ul>
</div>
<button type="button" class="btn btn-primary" (click)="dropdown.isOpen=!dropdown.isOpen">Toggle</button>

This comment was marked as off-topic.

description: `<p>Dropdown can be triggered by <code>show</code>, <code>hide</code> and
<code>toggle</code> methods from directive
<br>
Use method <code>toggle(true)</code> if you want create toggler, or <code>toggle(false)</code>

This comment was marked as off-topic.

<code>toggle</code> methods from directive
<br>
Use method <code>toggle(true)</code> if you want create toggler, or <code>toggle(false)</code>
if you want only close opened dropdown.

This comment was marked as off-topic.

anchor: 'trigger-by-isopen-property',
component: require('!!raw-loader?lang=typescript!./demos/trigger-by-isopen-property/trigger-by-isopen-property.ts'),
html: require('!!raw-loader?lang=markup!./demos/trigger-by-isopen-property/trigger-by-isopen-property.html'),
description: `<p>Dropdown can be shown or hidden by direct change of <code>isOpen</code> input property</p>`,

This comment was marked as off-topic.

@@ -1802,7 +1802,7 @@ export const ngdoc: any = {
},
{
"name": "toggle",
"description": "<p>Toggles an element’s popover. This is considered a “manual” triggering of\nthe popover.</p>\n",
"description": "<p>Toggles an element’s popover. This is considered a “manual” triggering of\nthe popover. With parameter true allow toggling, with parameter false\nonly hide opened dropdown. Parameter usage will be removed in 3rd ngx bootstrap release</p>\n",

This comment was marked as off-topic.

anchor: 'trigger-by-isopen-property',
component: require('!!raw-loader?lang=typescript!./demos/trigger-by-isopen-property/trigger-by-isopen-property.ts'),
html: require('!!raw-loader?lang=markup!./demos/trigger-by-isopen-property/trigger-by-isopen-property.html'),
description: `<p>Dropdown can be shown or hidden by changing of <code>isOpen</code> input property</p>`,

This comment was marked as off-topic.

@ghost ghost assigned IlyaSurmay Apr 5, 2018
@ghost ghost added the in progress label Apr 5, 2018
@YevheniiaMazur
Copy link
Author

Tested, looks good

@ghost ghost assigned valorkin Apr 24, 2018
@valorkin valorkin merged commit 523ea04 into development Apr 24, 2018
@ghost ghost removed the ready for merge label Apr 24, 2018
@valorkin valorkin deleted the fix-dropdown-demo-toggling branch April 24, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants