-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dropdown): decompose manual triggering demo #4116
Conversation
Codecov Report
@@ Coverage Diff @@
## development #4116 +/- ##
=============================================
Coverage ? 72.6%
=============================================
Files ? 254
Lines ? 8221
Branches ? 1469
=============================================
Hits ? 5969
Misses ? 1897
Partials ? 355
Continue to review full report at Codecov.
|
here</a></li> | ||
</ul> | ||
</div> | ||
<button type="button" class="btn btn-primary" (click)="dropdown.isOpen=!dropdown.isOpen">Toggle</button> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
description: `<p>Dropdown can be triggered by <code>show</code>, <code>hide</code> and | ||
<code>toggle</code> methods from directive | ||
<br> | ||
Use method <code>toggle(true)</code> if you want create toggler, or <code>toggle(false)</code> |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
<code>toggle</code> methods from directive | ||
<br> | ||
Use method <code>toggle(true)</code> if you want create toggler, or <code>toggle(false)</code> | ||
if you want only close opened dropdown. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
anchor: 'trigger-by-isopen-property', | ||
component: require('!!raw-loader?lang=typescript!./demos/trigger-by-isopen-property/trigger-by-isopen-property.ts'), | ||
html: require('!!raw-loader?lang=markup!./demos/trigger-by-isopen-property/trigger-by-isopen-property.html'), | ||
description: `<p>Dropdown can be shown or hidden by direct change of <code>isOpen</code> input property</p>`, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
demo/src/ng-api-doc.ts
Outdated
@@ -1802,7 +1802,7 @@ export const ngdoc: any = { | |||
}, | |||
{ | |||
"name": "toggle", | |||
"description": "<p>Toggles an element’s popover. This is considered a “manual” triggering of\nthe popover.</p>\n", | |||
"description": "<p>Toggles an element’s popover. This is considered a “manual” triggering of\nthe popover. With parameter true allow toggling, with parameter false\nonly hide opened dropdown. Parameter usage will be removed in 3rd ngx bootstrap release</p>\n", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
542e8be
to
84fc087
Compare
84fc087
to
603909f
Compare
anchor: 'trigger-by-isopen-property', | ||
component: require('!!raw-loader?lang=typescript!./demos/trigger-by-isopen-property/trigger-by-isopen-property.ts'), | ||
html: require('!!raw-loader?lang=markup!./demos/trigger-by-isopen-property/trigger-by-isopen-property.html'), | ||
description: `<p>Dropdown can be shown or hidden by changing of <code>isOpen</code> input property</p>`, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Tested, looks good |
PR Checklist
Closes: #4110
What was done:
isOpen
property instead of creating special method for it: