Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): update @types/webpack #3970

Merged
merged 1 commit into from
Mar 12, 2018
Merged

fix(test): update @types/webpack #3970

merged 1 commit into from
Mar 12, 2018

Conversation

IlyaSurmay
Copy link
Contributor

Fixes this error during ng test

Error: 
C:/Source/ngx-bootstrap/node_modules/@types/webpack/index.d.ts (530,28): Type 'typeof "C:/Source/ngx-bootstrap/node_modules/@types/tapable/index"' is not a constructor function type.,
C:/Source/ngx-bootstrap/node_modules/@types/webpack/index.d.ts (557,42): Type 'typeof "C:/Source/ngx-bootstrap/node_modules/@types/tapable/index"' is not a constructor function type.,
C:/Source/ngx-bootstrap/node_modules/@types/webpack/index.d.ts (573,46): Namespace '"C:/Source/ngx-bootstrap/node_modules/@types/tapable/index"' has no exported member 'Plugin'.,
C:/Source/ngx-bootstrap/node_modules/@types/webpack/index.d.ts (577,53): Namespace '"C:/Source/ngx-bootstrap/node_modules/@types/tapable/index"' has no exported member 'Plugin'.

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.

@IlyaSurmay IlyaSurmay requested a review from valorkin March 12, 2018 10:54
@ghost ghost assigned IlyaSurmay Mar 12, 2018
@ghost ghost added the in progress label Mar 12, 2018
@valorkin valorkin merged commit bcbe405 into development Mar 12, 2018
@ghost ghost removed the in progress label Mar 12, 2018
@valorkin valorkin deleted the fix-types-webpack branch March 12, 2018 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants