fix(demo): remove repetition id in demos #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaSurmay
previously approved these changes
Mar 7, 2018
|
Needs to fix conflicting files |
Codecov Report
@@ Coverage Diff @@
## development #3937 +/- ##
============================================
Coverage 72.23% 72.23%
============================================
Files 253 253
Lines 8238 8238
Branches 1565 1565
============================================
Hits 5951 5951
Misses 1866 1866
Partials 421 421
Continue to review full report at Codecov.
|
valorkin
previously approved these changes
Mar 29, 2018
|
@tarusin resolve conflicts |
|
Needs to fix conflict before testing |
|
@valorkin @YevheniiaMazur conflicts fixed |
YevheniiaMazur
added
ready for tests
in test
and removed
needs fix
ready for tests
labels
|
Got local errors and not actual files locally. Will retest this PR with @tarusin on Monday |
YevheniiaMazur
added
ready for tests
in test
and removed
in test
ready for tests
labels
|
Tested, looks good |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3936
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.