docs(modal): add demo for modal window with one tooltip and one popover in the body of the modal #3871

ghost · 2018-02-23T16:37:35Z

The demo for modal window was added with:

one tooltip
one popover
in the body of the modal ( as an example) .
You can see it in Modal window with tooltip and popover section

demo/src/app/components/+modal/modal-section.list.ts

+        anchor: 'modal-with-popups',
+        component: require('!!raw-loader?lang=typescript!./demos/modal-with-popups/modal-with-popups.ts'),
+        html: require('!!raw-loader?lang=markup!./demos/modal-with-popups/modal-with-popups.html'),
+        description: `<p>Add other components to modal window (<code>popover</code> and <code>tooltip</code> in this case)</p>`,


codecov · 2018-02-23T16:52:09Z

Codecov Report

Merging #3871 into development will decrease coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development    #3871      +/-   ##
===============================================
- Coverage        72.25%   72.21%   -0.05%     
===============================================
  Files              252      252              
  Lines             8237     8237              
  Branches          1565     1565              
===============================================
- Hits              5952     5948       -4     
- Misses            1865     1867       +2     
- Partials           420      422       +2

Impacted Files	Coverage Δ
src/chronos/i18n/pl.ts	`72.22% <0%> (-11.12%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4494459...e8a4cca. Read the comment docs.

ghost · 2018-02-26T10:24:04Z

@YevheniiaMazur please don't check this pr, while development isn't fixed

ghost · 2018-03-02T15:42:12Z

I've changed buttons_page_spec.ts to run tests (only add missing bracket )

ghost · 2018-03-02T15:59:25Z

@YevheniiaMazur updated my branch. this pr could be checked.

YevheniiaMazur · 2018-03-13T16:31:43Z

Needs to fix conflicting files

YevheniiaMazur · 2018-03-14T14:19:01Z

@svetoldo4444ka , please, update related to this PR issue
Also, please, update demo name and description for making it more clear due to this moments:

Modal window contains header and body and both can contain other components
Now demo name is modal-with-popups, but it contains only one popup and one tooltip, please, make this name closer to content

Otherwise, looks good

…lders

YevheniiaMazur · 2018-03-16T12:15:23Z

@svetoldo4444ka , please, use special words, described in GIT documentation for linking issue to PR
https://help.github.com/articles/closing-issues-using-keywords/

ghost · 2018-03-19T13:07:39Z

@YevheniiaMazur fixed

YevheniiaMazur · 2018-03-20T12:06:44Z

Why words tooltips and popovers in first sentence are marked as code, and at second are not? In both case it is not part of code, only elements' names. And, if I'm not wrong, with word any plurals are not used

Otherwise, looks good

ghost · 2018-03-21T13:17:38Z

@YevheniiaMazur @IlyaSurmay @EvilAlexei
was decided to mark any tooltips and popovers in the description section as code (because tooltip and popover name of component)

Description section was taken from bootstrap

… into docs-add-demo-modal-with-popover-tooltip

YevheniiaMazur · 2018-03-29T14:15:17Z

Tested, looks good

ghost changed the title ~~docs(dropdown): add demo for modal window with popover and tooltip~~ docs(modal): add demo for modal window with popover and tooltip Feb 23, 2018

IlyaSurmay suggested changes Feb 23, 2018

View reviewed changes

IlyaSurmay added comp(docs) needs fix labels Feb 23, 2018

IlyaSurmay previously approved these changes Feb 23, 2018

View reviewed changes

IlyaSurmay added ready for tests and removed needs fix labels Feb 23, 2018

ghost dismissed IlyaSurmay’s stale review via b63df3f March 1, 2018 15:34

docs(modal): update branch from development, fix conflicts

c2e25f0

IlyaSurmay previously approved these changes Mar 2, 2018

View reviewed changes

YevheniiaMazur added needs fix and removed ready for tests labels Mar 13, 2018

ghost dismissed IlyaSurmay’s stale review via 74b109f March 14, 2018 12:44

IlyaSurmay previously approved these changes Mar 14, 2018

View reviewed changes

IlyaSurmay added ready for tests and removed needs fix labels Mar 14, 2018

YevheniiaMazur added in test and removed ready for tests labels Mar 14, 2018

YevheniiaMazur added needs fix and removed in test labels Mar 14, 2018

ghost changed the title ~~docs(modal): add demo for modal window with popover and tooltip~~ docs(modal): add demo for modal window with other components Mar 15, 2018

dosc(modal): fix conflicts, change name of component selectors and fo…

791bde2

…lders

ghost dismissed IlyaSurmay’s stale review via 791bde2 March 15, 2018 14:39

ghost changed the title ~~docs(modal): add demo for modal window with other components~~ docs(modal): add demo for modal window with one tooltip and one popover in the body of the modal Mar 16, 2018

docs(modal): change name of section and description

06bcbf4

ghost assigned IlyaSurmay Mar 16, 2018

ghost added the in progress label Mar 16, 2018

IlyaSurmay previously approved these changes Mar 16, 2018

View reviewed changes

IlyaSurmay added ready for tests and removed in progress needs fix labels Mar 16, 2018

YevheniiaMazur added needs fix and removed ready for tests labels Mar 16, 2018

YevheniiaMazur added ready for tests in test and removed needs fix ready for tests labels Mar 20, 2018

YevheniiaMazur added needs fix and removed in test labels Mar 20, 2018

Merge branch 'development' of github.com:svetoldo4444ka/ngx-bootstrap…

e8a4cca

… into docs-add-demo-modal-with-popover-tooltip

ghost dismissed IlyaSurmay’s stale review via e8a4cca March 21, 2018 13:27

valorkin added ready for tests and removed needs fix labels Mar 29, 2018

YevheniiaMazur added in test and removed ready for tests labels Mar 29, 2018

YevheniiaMazur added ready for merge and removed in test labels Mar 29, 2018

valorkin merged commit 8787d6b into valor-software:development Apr 5, 2018

ghost removed the ready for merge label Apr 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(modal): add demo for modal window with one tooltip and one popover in the body of the modal #3871

docs(modal): add demo for modal window with one tooltip and one popover in the body of the modal #3871

ghost commented Feb 23, 2018 •

edited by ghost

Loading

This comment was marked as off-topic.

codecov bot commented Feb 23, 2018 •

edited

Loading

ghost commented Feb 26, 2018

ghost commented Mar 2, 2018

ghost commented Mar 2, 2018

YevheniiaMazur commented Mar 13, 2018

YevheniiaMazur commented Mar 14, 2018 •

edited

Loading

YevheniiaMazur commented Mar 16, 2018 •

edited

Loading

ghost commented Mar 19, 2018

YevheniiaMazur commented Mar 20, 2018

ghost commented Mar 21, 2018

YevheniiaMazur commented Mar 29, 2018

docs(modal): add demo for modal window with one tooltip and one popover in the body of the modal #3871

docs(modal): add demo for modal window with one tooltip and one popover in the body of the modal #3871

Conversation

ghost commented Feb 23, 2018 • edited by ghost Loading

This comment was marked as off-topic.

codecov bot commented Feb 23, 2018 • edited Loading

Codecov Report

ghost commented Feb 26, 2018

ghost commented Mar 2, 2018

ghost commented Mar 2, 2018

YevheniiaMazur commented Mar 13, 2018

YevheniiaMazur commented Mar 14, 2018 • edited Loading

YevheniiaMazur commented Mar 16, 2018 • edited Loading

ghost commented Mar 19, 2018

YevheniiaMazur commented Mar 20, 2018

ghost commented Mar 21, 2018

YevheniiaMazur commented Mar 29, 2018

ghost commented Feb 23, 2018 •

edited by ghost

Loading

codecov bot commented Feb 23, 2018 •

edited

Loading

YevheniiaMazur commented Mar 14, 2018 •

edited

Loading

YevheniiaMazur commented Mar 16, 2018 •

edited

Loading