Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(collapse): decompose Basic demo #3792

Conversation

artolshansky
Copy link
Contributor

close #3789

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Feb 15, 2018

Codecov Report

Merging #3792 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3792   +/-   ##
============================================
  Coverage        72.24%   72.24%           
============================================
  Files              252      252           
  Lines             8233     8233           
  Branches          1563     1563           
============================================
  Hits              5948     5948           
  Misses            1863     1863           
  Partials           422      422
Impacted Files Coverage Δ
src/popover/popover-container.component.ts 90.9% <0%> (ø) ⬆️
src/tooltip/tooltip-container.component.ts 72.22% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898251d...838d1d4. Read the comment docs.

@artolshansky artolshansky force-pushed the docs-decompose-basic-collapse branch from 1ad47f2 to 7e08f40 Compare February 16, 2018 10:34
@@ -29,6 +30,13 @@ export const demoComponentContent: ContentSection[] = [
html: require('!!raw-loader?lang=markup!./demos/basic/basic.html'),
outlet: CollapseDemoComponent
},
{
title: 'Collapsed & expanded events listening',

This comment was marked as off-topic.

anchor: 'events',
component: require('!!raw-loader?lang=typescript!./demos/events/events'),
html: require('!!raw-loader?lang=markup!./demos/events/events.html'),
outlet: CollapseDemoEventsComponent

This comment was marked as off-topic.

@artolshansky artolshansky force-pushed the docs-decompose-basic-collapse branch from 7e08f40 to 52802b1 Compare February 23, 2018 15:01
@YevheniiaMazur
Copy link

Needs to fix conflicts

@artolshansky artolshansky deleted the docs-decompose-basic-collapse branch March 13, 2018 16:29
@valorkin
Copy link
Member

@olshansky why close PR and delete branch?

@artolshansky
Copy link
Contributor Author

@valorkin mistake
open same pr #3977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs(collapse): decompose Basic demo
4 participants