Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collapse): fix wrong display value DO NOT MERGE #3401

Closed
wants to merge 1 commit into from

Conversation

IlyaSurmay
Copy link
Contributor

@IlyaSurmay IlyaSurmay commented Jan 4, 2018

BREAKS ACCORDION, DO NOT MERGE
Fixes #3032
Fixes #2473

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.

@IlyaSurmay IlyaSurmay requested a review from valorkin January 4, 2018 12:12
@ghost ghost assigned IlyaSurmay Jan 4, 2018
@ghost ghost added the in progress label Jan 4, 2018
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #3401 into development will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3401      +/-   ##
===============================================
- Coverage        65.03%   64.99%   -0.04%     
===============================================
  Files              210      210              
  Lines             5691     5694       +3     
  Branches          1000     1004       +4     
===============================================
  Hits              3701     3701              
  Misses            1724     1724              
- Partials           266      269       +3
Impacted Files Coverage Δ
src/collapse/collapse.directive.ts 90.47% <57.14%> (-6.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ad82bb...2358f8c. Read the comment docs.

@IlyaSurmay IlyaSurmay changed the title fix(collapse): fix wrong display value fix(collapse): fix wrong display value DO NOT MERGE Jan 4, 2018
@Domainv Domainv closed this Apr 11, 2019
@ghost ghost removed the blocked label Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants