Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collapse): custom display styles #2893

Closed

Conversation

brunocroh
Copy link
Contributor

Added feature of issue #2473

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Oct 23, 2017

Codecov Report

Merging #2893 into development will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #2893      +/-   ##
==============================================
+ Coverage        70.69%   70.7%   +0.01%     
==============================================
  Files              137     137              
  Lines             4159    4161       +2     
  Branches           735     735              
==============================================
+ Hits              2940    2942       +2     
  Misses             914     914              
  Partials           305     305
Impacted Files Coverage Δ
src/collapse/collapse.directive.ts 90.24% <100%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 479b046...436530d. Read the comment docs.

@valorkin
Copy link
Member

valorkin commented Nov 2, 2017

@brunocroh hey, thanks for PR, we are cutting of v2 of ngx-bs, and dropping ng v2 support
so we will add customizable Animation support

@valorkin valorkin closed this Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants