Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typeahead.directive.ts #2320

Merged
merged 3 commits into from
Oct 13, 2017

Conversation

arun-haridas
Copy link
Contributor

Workaround for the issue #1919 (typeahead): show available choices onFocus when minLength == 0

Arun Haridas (DECO) added 2 commits July 29, 2017 17:36
Workaround for the issue valor-software#1919  (typeahead): show available choices onFocus when minLength == 0
@codecov
Copy link

codecov bot commented Aug 2, 2017

Codecov Report

Merging #2320 into development will increase coverage by 5.46%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2320      +/-   ##
===============================================
+ Coverage        70.44%   75.91%   +5.46%     
===============================================
  Files              137      121      -16     
  Lines             4094     3612     -482     
  Branches           712      474     -238     
===============================================
- Hits              2884     2742     -142     
+ Misses             912      745     -167     
+ Partials           298      125     -173
Impacted Files Coverage Δ
src/typeahead/typeahead.directive.ts 78.08% <100%> (+6.19%) ⬆️
src/positioning/ng-positioning.ts 62.92% <0%> (-11%) ⬇️
src/timepicker/reducer/timepicker.reducer.ts 90% <0%> (-1.67%) ⬇️
src/timepicker/timepicker-controls.util.ts 95.31% <0%> (-0.64%) ⬇️
src/spec/ng-bootstrap/test/common.ts 90.32% <0%> (-0.31%) ⬇️
src/timepicker/timepicker.utils.ts 92.2% <0%> (-0.3%) ⬇️
src/alert/alert.module.ts 100% <0%> (ø) ⬆️
src/pagination/pagination.config.ts 100% <0%> (ø) ⬆️
src/accordion/accordion.config.ts 100% <0%> (ø) ⬆️
src/dropdown/bs-dropdown.state.ts 100% <0%> (ø) ⬆️
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5613042...6955ffd. Read the comment docs.

@valorkin valorkin merged commit 7635468 into valor-software:development Oct 13, 2017
@valorkin valorkin added this to the v2.0.0 milestone Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants