Fix (Typeahead): Typeahead shows list on focus when minLenth is 0. #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1918 +/- ##
============================================
Coverage 85.93% 85.93%
============================================
Files 78 78
Lines 2098 2098
Branches 273 273
============================================
Hits 1803 1803
Misses 202 202
Partials 93 93
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1559
Currently typeahead does not show list on focus when typeaheadMinLength="0" even is such behaviour is documented.
onFocus method is comparing minLength with 0, while the angular sets input property to string '0' and no event is emitted.
Fixed the issue by replacing === with == in the comparison.