fix dropdown missing outputs / emits on toggle, include & fix tests #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1916 +/- ##
===============================================
- Coverage 85.93% 85.92% -0.02%
===============================================
Files 78 86 +8
Lines 2098 2280 +182
Branches 273 292 +19
===============================================
+ Hits 1803 1959 +156
- Misses 202 222 +20
- Partials 93 99 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1915
added isOpenChange output to directive, added emits on show/hide for onShown/onHidden ( I'm not sure we should emit there something, in component loader componentRef.instance emitted btw.
moved spec file to spec/ folder & fixed tests, added few, removed tests related to dropdown-toggle class since it's not actual according to docs.
PS: currently there are no easy way to knew when dropdown is open/closed and no container are set for user, because no outputs provided, also that quite hard to close it programatically since isOpen on context is desynced with inner one only using various workarounds. Would be great if build will be available after we fix that.