Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alerts): after dismissing alert are not removing from DOM #3608

Closed
YevheniiaMazur opened this issue Jan 31, 2018 · 2 comments
Closed

fix(alerts): after dismissing alert are not removing from DOM #3608

YevheniiaMazur opened this issue Jan 31, 2018 · 2 comments
Labels
comp(alerts) issue

Comments

@YevheniiaMazur
Copy link

Bug description or feature request:

WTR

  • Go to Alerts demo page
  • Scroll down to any alert with dismissible option (Dismissing demo or Dismiss on timeout)
  • Find alert in DOM
  • Dismiss alert (or wait time, after what it dismissed)
  • Look at DOM again
  • Add new alert
  • Repeat steps 3-6 several times
    alertnotremoved
    multiplealertsatdom

Expected result

All alerts after dismissing are removed from DOM

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: all supported

Angular: all supported

Bootstrap: all supported
@tarusin tarusin mentioned this issue Jan 31, 2018
Closed
19 tasks
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 1, 2018
@IraErshova
fix(alerts): after dismissing alert are not removing from DOM valor-s…
530b34b 
…oftware#3608

Fix removing alert from DOM after its dismissing

Close valor-software#3608
@IraErshova IraErshova mentioned this issue Feb 1, 2018
Merged
3 tasks
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 5, 2018
@IraErshova
fix(alerts): after dismissing alert are not removing from DOM valor-s…
60e528c 
…oftware#3608

Fix removing alert from DOM after its dismissing

Close valor-software#3608
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 8, 2018
@IraErshova
fix(alerts): after dismissing alert are not removing from DOM valor-s…
05d8326 
…oftware#3608

Fix removing alert from DOM after its dismissing

Close valor-software#3608
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 8, 2018
@IraErshova
fix(alerts): after dismissing alert are not removing from DOM valor-s…
b73e53f 
…oftware#3608

Fix removing alert from DOM after its dismissing

Close valor-software#3608
IraErshova added a commit to IraErshova/ngx-bootstrap that referenced this issue Feb 22, 2018
@IraErshova
fix(alerts): after dismissing alert are not removing from DOM valor-s…
f1583a9 
…oftware#3608

Fix removing alert from DOM after its dismissing

Close valor-software#3608
@ghost ghost removed the in progress label Feb 22, 2018
valorkin pushed a commit that referenced this issue Feb 22, 2018
@IraErshova @valorkin
fix(alerts): after dismissing alert are not removing from DOM #3608 (#…
479778a 
…3622)

Fix removing alert from DOM after its dismissing

Close #3608
@martibenj
Copy link

Is there some update about this issue ? Will it be released ?

@valorkin
Copy link
Member

I suppose it's already published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(alerts) issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@valorkin @EvilAlexei @martibenj @YevheniiaMazur