Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): support [email protected]'s 'fullTemplateTypeCheck' #3455

Closed
amitport opened this issue Jan 14, 2018 · 1 comment · Fixed by #3462
Closed

fix(datepicker): support [email protected]'s 'fullTemplateTypeCheck' #3455

amitport opened this issue Jan 14, 2018 · 1 comment · Fixed by #3462

Comments

@amitport
Copy link

Bug description or feature request:

when trying to build with "fullTemplateTypeCheck": true:

node_modules\ngx-bootstrap\datepicker\daypicker.component.d.ts.DayPickerComponent.html(2,62): : Property 'uniqueId' is protected and only accessible within class 'DatePickerInnerComponent' and its subclasses.
node_modules\ngx-bootstrap\datepicker\daypicker.component.d.ts.DayPickerComponent.html(18,17): : Property 'uniqueId' is protected and only accessible within class 'DatePickerInnerComponent' and its subclasses.
node_modules\ngx-bootstrap\datepicker\daypicker.component.d.ts.DayPickerComponent.html(20,17): : Expected 1 arguments, but got 0.
node_modules\ngx-bootstrap\datepicker\monthpicker.component.d.ts.MonthPickerComponent.html(9,17): : Property 'uniqueId' is protected and only accessible within class 'DatePickerInnerComponent' and its subclasses.
node_modules\ngx-bootstrap\datepicker\monthpicker.component.d.ts.MonthPickerComponent.html(11,17): : Expected 1 arguments, but got 0.
node_modules\ngx-bootstrap\datepicker\yearpicker.component.d.ts.YearPickerComponent.html(10,17): : Property 'uniqueId' is protected and only accessible within class 'DatePickerInnerComponent' and its subclasses.
node_modules\ngx-bootstrap\datepicker\yearpicker.component.d.ts.YearPickerComponent.html(12,17): : Expected 1 arguments, but got 0.

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: 2.0.0-rc.0
Angular: 5.2.0
Bootstrap: 4.0.0-beta.2

Build system: Angular CLI, System.js, webpack, starter seed:

Angular CLI

@valorkin
Copy link
Member

nice! it's nice reason for small PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants