Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modals): after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears #3313

Closed
YevheniiaMazur opened this issue Dec 18, 2017 · 0 comments · Fixed by #3605
Closed

fix(modals): after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears #3313

YevheniiaMazur opened this issue Dec 18, 2017 · 0 comments · Fixed by #3605
Labels
comp(demo) comp(modal) issue prio: medium

Comments

@YevheniiaMazur
Copy link

YevheniiaMazur commented Dec 18, 2017 •
edited
Loading

Bug description:

  • Open ngx-bootstrap demo at Safari browser
  • Open modal demo page
  • Click on any button for showing modal
  • Press Esc button

Expected result

After pressing Esc button Modal hides, and browser window doesn't change it's size

modaldemoissue

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap: all supported

Angular: all supported

Bootstrap: all supported
@v1ktoryy v1ktoryy mentioned this issue Jan 17, 2018
Closed
24 tasks
@EvilAlexei EvilAlexei mentioned this issue Jan 18, 2018
Closed
37 tasks
@EvilAlexei EvilAlexei changed the title fix(demo modals): after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears fix(modals): after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears Jan 31, 2018
artolshansky added a commit to artolshansky/ngx-bootstrap that referenced this issue Jan 31, 2018
@artolshansky
fix(modals): fix minimize Safari after press esc
9f66f03 
fix: after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears

close valor-software#3313
@artolshansky artolshansky mentioned this issue Jan 31, 2018
Merged
2 tasks
artolshansky added a commit to artolshansky/ngx-bootstrap that referenced this issue Mar 2, 2018
@artolshansky
fix(modals): fix minimize Safari after press esc
5f442f1 
fix: after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears

close valor-software#3313
artolshansky added a commit to artolshansky/ngx-bootstrap that referenced this issue Mar 2, 2018
@artolshansky
fix(modals): fix minimize Safari after press esc
11293b6 
fix: after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears

close valor-software#3313
valorkin pushed a commit that referenced this issue Mar 13, 2018
@artolshansky @valorkin
fix(modals): fix minimize Safari after press esc (#3605)
9c8cef4 
fix: after opening any modal and pressing Esc button, browser minimize and only after that modal dissappears

close #3313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(demo) comp(modal) issue prio: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modals): fix minimize Safari after press esc artolshansky/ngx-bootstrap
2 participants
@EvilAlexei @YevheniiaMazur