-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datepicker input is always dirty when ngModel is a non-null value #3014
Comments
We also have the same issue. May I know when it will get fixed? |
This is actually a big problem - it's breaking form validation. Can I help with fixing it if you guys are too busy? |
Sure, that would be awesome :) |
ok, seems I have fixed it, testing |
Excellent news, thanks @valorkin ! |
Will be published this thusday, but you can check here http://ngx-bootstrap.surge.sh/#/datepicker |
Hi @valorkin Will you be publishing a new release with this fix? I'm not trying to rush you - just checking so we can set our release timeline :) |
I was planning to do release yestarday, but QA took couple of dayoffs, |
Fantastic, thank you! |
@valorkin |
@chanakyanet could you provide a sample please? |
@valorkin |
Was this fix ever released because I'm having the same issue. |
i came across this issue and a possible workaround may be calling markAsPristine() and markAsUntouched() form methods after setting the null value. it might work on some cases. |
Bug description or feature request:
The datepicker component has the isDirty flag set shortly after being loaded when ngModel is not null.
Plunkr
https://plnkr.co/edit/odlMZcGA7WzuO75TSeCD?p=preview
Versions of ngx-bootstrap, Angular, and Bootstrap:
ngx-bootstrap: 1.9.3
Angular: 4.3.2
Bootstrap: bootstrap-sass 3.3.7
Build system: Angular CLI, System.js, webpack, starter seed:
Webpack
yo angular2-typescript generator version 0.8.1.
The text was updated successfully, but these errors were encountered: