Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timepicker): remove inline styling #2496

Closed
ebakunin opened this issue Aug 23, 2017 · 3 comments
Closed

feat(timepicker): remove inline styling #2496

ebakunin opened this issue Aug 23, 2017 · 3 comments
Labels
comp(timepicker) effort1: easy (hours)

Comments

@ebakunin
Copy link

The text inputs in the timepicker have inline styling. This makes it impossible to customize the look and feel of the component. Can the inline style be removed?
@valorkin
Copy link
Member

@ebakunin they must be removed

@valorkin valorkin changed the title Inline styling on the timepicker feat(timepicker): remove inline styling Aug 24, 2017
@ebakunin
Copy link
Author

@valorkin, I meant will Valor be removing the inline styling sometime in the future?

@valorkin
Copy link
Member

Yes, they will

@LimarenkoDenis LimarenkoDenis mentioned this issue Oct 6, 2017
Merged
5 tasks
valorkin pushed a commit that referenced this issue Oct 20, 2017
@LimarenkoDenis @valorkin
feat(timepicker): remove inline styling, #2496 (#2812)
417d0a2 
* feat(timepicker): remove inline styling, 2496

* replaced inline-styles to component-scoped styles

* refactor(timepicker): change css classes names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(timepicker) effort1: easy (hours)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@valorkin @ebakunin @IlyaSurmay