Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rating): rating titles change format part way through. #1751

Closed
DouglasWebster opened this issue Mar 14, 2017 · 0 comments · Fixed by #4620
Closed

fix(rating): rating titles change format part way through. #1751

DouglasWebster opened this issue Mar 14, 2017 · 0 comments · Fixed by #4620

Comments

@DouglasWebster
Copy link
Contributor

The ratings module defaults the first five titles to one, two, three, four and five then further titles progress 6, 7, 8 ... This give a change of format to hovered text on the icons as a user progresses along the line.
Would it not be more consistent to default to 1, 2, 3, 4, 5 and leave it to the user to override this in the [titles] section if they want a word format to show on hovering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants