-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- Implement of promise for filter function; #1105
base: development
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1105 +/- ##
===============================================
+ Coverage 34.72% 34.91% +0.19%
===============================================
Files 10 10
Lines 550 547 -3
Branches 80 83 +3
===============================================
Hits 191 191
+ Misses 341 336 -5
- Partials 18 20 +2
Continue to review full report at Codecov.
|
Can we get this pulled? |
Yea sure |
Sorry, comment wasn't direct at you, but to hopefully catch the eye of one of the maintainers. |
File filter function from this commit now can be resolved from both boolean and Promise<boolean>