Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a lua debugger bug that prevented use of 'server' for server.call invocations. #303

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Fixing a lua debugger bug that prevented use of 'server' for server.call invocations. #303

merged 2 commits into from
Apr 11, 2024

Conversation

parthpatel
Copy link
Member

@parthpatel parthpatel commented Apr 11, 2024 •
edited
Loading 

lua debugger> server ping
<redis> ping
<reply> "+PONG"
lua debugger> redis ping
<redis> ping
<reply> "+PONG"
  • I also searched for lua debugger related unit tests to add coverage for this but did not find any relevant test to modify. Leaving it at that for now.

@parthpatel
fixing a lua debugger bug that prevented use of 'server' for server.c…
391fc3b 
…all invocations.

* Tested it on local instance. This was originally part of #288 but I am pushing this separately, so that we can easily merge it into the upcoming release.

```
lua debugger> server ping
<redis> ping
<reply> "+PONG"
lua debugger> redis ping
<redis> ping
<reply> "+PONG"
```

Signed-off-by: Parth Patel <[email protected]>
@parthpatel
Adding a test for the lua debugger bugfix. I don't understand TCL ver…
0893406 
…y well but tried to implement as close to the patterns in the file as possible.

Signed-off-by: Parth Patel <[email protected]>
PingXie
PingXie approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@PingXie PingXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

madolson
madolson approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, played around with it a bunch and I think this seems good.

@madolson madolson merged commit 644692d into valkey-io:unstable Apr 11, 2024
14 checks passed
madolson pushed a commit that referenced this pull request Apr 11, 2024
@parthpatel @madolson
Fixing a lua debugger bug that prevented use of 'server' for server.c…
10a634c 
…all invocations. (#303)

* Tested it on local instance. This was originally part of
#288 but I am pushing this
separately, so that we can easily merge it into the upcoming release.

```
lua debugger> server ping
<redis> ping
<reply> "+PONG"
lua debugger> redis ping
<redis> ping
<reply> "+PONG"
```

* I also searched for lua debugger related unit tests to add coverage
for this but did not find any relevant test to modify. Leaving it at
that for now.

---------

Signed-off-by: Parth Patel <[email protected]>
@parthpatel parthpatel deleted the temp branch April 11, 2024 22:57
zuiderkwast pushed a commit to zuiderkwast/placeholderkv that referenced this pull request Apr 17, 2024
@parthpatel @zuiderkwast
Fixing a lua debugger bug that prevented use of 'server' for server.c…
885c2cf 
…all invocations. (valkey-io#303)

* Tested it on local instance. This was originally part of
valkey-io#288 but I am pushing this
separately, so that we can easily merge it into the upcoming release.

```
lua debugger> server ping
<redis> ping
<reply> "+PONG"
lua debugger> redis ping
<redis> ping
<reply> "+PONG"
```

* I also searched for lua debugger related unit tests to add coverage
for this but did not find any relevant test to modify. Leaving it at
that for now.

---------

Signed-off-by: Parth Patel <[email protected]>
PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this pull request Apr 24, 2024
@parthpatel @PatrickJS
Fixing a lua debugger bug that prevented use of 'server' for server.c…
c507c28 
…all invocations. (valkey-io#303)

* Tested it on local instance. This was originally part of
valkey-io#288 but I am pushing this
separately, so that we can easily merge it into the upcoming release.

```
lua debugger> server ping
<redis> ping
<reply> "+PONG"
lua debugger> redis ping
<redis> ping
<reply> "+PONG"
```

* I also searched for lua debugger related unit tests to add coverage
for this but did not find any relevant test to modify. Leaving it at
that for now.

---------

Signed-off-by: Parth Patel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madolson madolson madolson approved these changes

@PingXie PingXie PingXie approved these changes

@zuiderkwast zuiderkwast Awaiting requested review from zuiderkwast

Assignees
No one assigned
Labels
None yet
Projects
Valkey 7.2
Status: Backported
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthpatel @PingXie @madolson