Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cross version testing for moduleapi tests #1655

Merged

Conversation

hpatro
Copy link
Collaborator

@hpatro hpatro commented Feb 3, 2025

Fixes: #1654

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.94%. Comparing base (e7dbce3) to head (79f995e).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1655      +/-   ##
============================================
- Coverage     70.94%   70.94%   -0.01%     
============================================
  Files           121      121              
  Lines         65225    65225              
============================================
- Hits          46276    46273       -3     
- Misses        18949    18952       +3     

see 11 files with indirect coverage changes

@hpatro hpatro requested a review from zuiderkwast February 3, 2025 18:23
@hpatro hpatro changed the title Enable cross version tests for moduleapi Enable cross version testing for moduleapi tests Feb 3, 2025
Copy link
Contributor

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, embarrassing we missed enabling it in the first PR. :)

Now we can see this in the CI job output:

[ok]: set up cluster (206 ms)
[ok]: Send cluster message via module from latest to other server (5 ms)
[ok]: Send cluster message via module from other server to latest (2 ms)

https://github.com/valkey-io/valkey/actions/runs/13119842270/job/36602987372?pr=1655#step:6:285

Looks good!

@hpatro hpatro merged commit 9f89c48 into valkey-io:unstable Feb 3, 2025
49 checks passed
@zuiderkwast
Copy link
Contributor

And the light-weight one is even faster:

[ok]: Cluster module send message API - VM_SendClusterMessage (1 ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable moduleapi test to run with cross version valkey server
2 participants