deflake tracking-redir-broken test #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This address 2 issues: 1. It is possible (somehow) that the inner server client (r) was not working resp 3 when entering this test. this makes sure it does. 2. in case the test failed it might leave the redirection client closed. there is a cross test assumption it should be open, so moved most of the assert checks to the end of the test. Signed-off-by: Ran Shidlansik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1628 +/- ##
============================================
- Coverage 70.94% 70.85% -0.09%
============================================
Files 121 121
Lines 65132 65174 +42
============================================
- Hits 46207 46180 -27
- Misses 18925 18994 +69 |
Comment on lines
-250
to
-252
| assert {$res >= 0} | ||
| # Consume PING reply | ||
| assert_equal PONG [r read] |
There was a problem hiding this comment.
why this fail? Because the r is not in resp3?
There was a problem hiding this comment.
I suspect that it did somehow. maybe the 'r' is disconnected and reconnected at some point
Signed-off-by: Ran Shidlansik <[email protected]>
enjoy-binbin
approved these changes
Jan 28, 2025
enjoy-binbin
pushed a commit
to enjoy-binbin/valkey
that referenced
this pull request
Feb 2, 2025
This address 2 issues: 1. It is possible (somehow) that the inner server client (r) was not working resp 3 when entering this test. this makes sure it does. 2. in case the test failed it might leave the redirection client closed. there is a cross test assumption it should be open, so moved most of the assert checks to the end of the test. example fail: https://github.com/valkey-io/valkey/actions/runs/12979601179/job/36195523412 --------- Signed-off-by: Ran Shidlansik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address 2 issues:
It is possible (somehow) that the inner server client (r) was not working resp 3 when entering this test.
this makes sure it does.
in case the test failed it might leave the redirection client closed. there is a cross test assumption it should be open, so moved most of the assert checks to the end of the test.
example fail: https://github.com/valkey-io/valkey/actions/runs/12979601179/job/36195523412